AppImage / AppImage/appimage.github.io

Collaborator push into PR during the CI upload of data test running causes upload to stop

Aperta
#2,732 6 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Shell
Stelle
374
Fork
769
Merge medio
4g 10h
PR unite (30g)
8

Descrizione

In case I create a pull request and all the conditions pass, the database and apps folder is not updated since I'm not the owner. It shall be pushed only when owner pushes to the branch.

But suppose, I create a PR after which owner actually pushes to it (dummy) to generate the files but, I update the fork's branch before the test for the owner's push is completed then the action running on owner's push is cancelled and hence the files in the database/ and apps/ is not pushed.

Then the PR may be merged to wrongly assume that the required files have already been generated and added when it is in fact so. See #2728 and 28a5eb3

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.