AppImage / AppImage/appimage.github.io

Collaborator push into PR during the CI upload of data test running causes upload to stop

Open
#2,732 6 comments 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
374
Forks
769
Avg merge
4d 10h
Merged PRs (30d)
8

Description

In case I create a pull request and all the conditions pass, the database and apps folder is not updated since I'm not the owner. It shall be pushed only when owner pushes to the branch.

But suppose, I create a PR after which owner actually pushes to it (dummy) to generate the files but, I update the fork's branch before the test for the owner's push is completed then the action running on owner's push is cancelled and hence the files in the database/ and apps/ is not pushed.

Then the PR may be merged to wrongly assume that the required files have already been generated and added when it is in fact so. See #2728 and 28a5eb3

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.