AppImage / AppImage/AppImageKit

Handle Gtk+ better

未關閉
#906 9 則留言 1 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
沒有語言資料
星號
9.4k
分支
588
PR 合併指標
30 天內沒有已合併 PR

描述

Currently we are bundling `libgtk-3.so.0` and `libgdk-3.so.0` but not the resources (e.g., themes) that go with them.

This results in

![bad](https://user-images.githubusercontent.com/2480569/51072351-13b36300-1657-11e9-988d-54bd9d76e77a.png)

when it should be

![good](https://user-images.githubusercontent.com/2480569/51072352-16ae5380-1657-11e9-96ac-99fef1361739.png)

```
(AppRun:7980): Gtk-WARNING **: 11:40:02.419: Theme parsing error: gtk-contained.css:4322:148: Missing name of pseudo-class

(AppRun:7980): Gtk-WARNING **: 11:40:02.419: Theme parsing error: gtk-contained.css:4367:14: 'min-height' is not a valid property name

(AppRun:7980): Gtk-WARNING **: 11:40:02.420: Theme parsing error: gtk-contained.css:4587:23: No property named '-gtk-icon-transform'
```

We should either __not__ bundle `libgtk-3.so.0` and `libgdk-3.so.0`, or __also__ bundle the resources (e.g., themes) that go with them.

With something like `GTK_EXE_PREFIX=squashfs-root/usr/ GTK_THEME=Adwaita squashfs-root/AppRun` it may be possible to load a bundled Gtk+ theme rather than the system's one, which is broken for us most of the time.

More information:
https://developer.gnome.org/gtk3/stable/gtk-running.html

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。