AppHouseKitchen / AppHouseKitchen/AlDente-Battery_Care_and_Monitoring

Privileged Helper Application exposes SMC interface

未關閉
#674 0 則留言 10 個 reaction 已指派 0 人 在 GitHub 檢視
enhancement
主要語言
Swift
星號
9.2k
分支
332
PR 合併指標
30 天內沒有已合併 PR

描述

The latest release of this app ships with a Privileged Helper App that exposes an SMC interface [1] that takes caller-specified key names without a whitelist [2]. There are obvious security concerns with not sanity-checking the key names intended to be exposed at the high-security level (helper). To not entirely eliminate this intentional security boundary from Apple, please consider matching the supplied key names against a whitelist. Or, much better yet, do not have any direct SMC exposure, but instead abstract the operations (e.g. expose `setSMCBatteryXYZ` over `setSMCByte` or alike).

[1] https://github.com/davidwernhart/AlDente/blob/4d610731eaa3d4b0eeac0298150b729c9a3ff747/Common/HelperToolProtocol.swift#L19-L21

[2] https://github.com/davidwernhart/AlDente/blob/4d610731eaa3d4b0eeac0298150b729c9a3ff747/com.davidwernhart.Helper/HelperTool.swift#L27-L53

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。