AppHouseKitchen / AppHouseKitchen/AlDente-Battery_Care_and_Monitoring

Privileged Helper Application exposes SMC interface

Open
#674 0 comments 10 reactions 0 assignees View on GitHub
enhancement
Dominant language
Swift
Stars
9.2k
Forks
332
PR merge metrics
No merged PRs in 30d

Description

The latest release of this app ships with a Privileged Helper App that exposes an SMC interface [1] that takes caller-specified key names without a whitelist [2]. There are obvious security concerns with not sanity-checking the key names intended to be exposed at the high-security level (helper). To not entirely eliminate this intentional security boundary from Apple, please consider matching the supplied key names against a whitelist. Or, much better yet, do not have any direct SMC exposure, but instead abstract the operations (e.g. expose `setSMCBatteryXYZ` over `setSMCByte` or alike).

[1] https://github.com/davidwernhart/AlDente/blob/4d610731eaa3d4b0eeac0298150b729c9a3ff747/Common/HelperToolProtocol.swift#L19-L21

[2] https://github.com/davidwernhart/AlDente/blob/4d610731eaa3d4b0eeac0298150b729c9a3ff747/com.davidwernhart.Helper/HelperTool.swift#L27-L53

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.