AppFlowy-IO / AppFlowy-IO/appflowy-editor

[Bug] replaceText has the possibility of throwing `Bad state: no element`

Abierto
#767 0 comentarios 0 reacciones 0 asignados Ver en GitHub
bug p0
Lenguaje dominante
Dart
Estrellas
684
Forks
329
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

### Bug Description

The transaction of `replaceText` does not check the length of the Delta before calling `.first`.

### How to Reproduce

Immediately after inserting a TextDelta with no attribute, call replaceText.

Eg.
```
final transaction = editorState.transaction
..insertTextDelta(
node,
selection.end.offset,
Delta(operations: [TextInsert('insert')]),
)
..replaceText(
node,
selection.end.offset - 3,
3,
'replacement',
);
```

### Expected Behavior

Change the code in `replaceText`:
```
var newAttributes = attributes;
if (index != 0 && attributes == null) {
newAttributes = delta.slice(max(index - 1, 0), index).first.attributes;
if (newAttributes == null) {
final slicedDelta = delta.slice(index, index + length);
if (slicedDelta.isNotEmpty) {
newAttributes = slicedDelta.first.attributes;
}
}
}
```
To add a required check and make sure the logic is correct.

Specifically the call to `.first` on `delta.slice(max(index - 1, 0), index)` is what might fail.

### Operating System

*

### AppFlowy Editor Version(s)

main

### Screenshots

_No response_

### Additional Context

_No response_

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.