AppFlowy-IO / AppFlowy-IO/appflowy-editor

[Bug] ValueNotifier disposed exception when reopening page with shrinkWrap=true EditorScrollController

Abierto
#1,151 0 comentarios 1 reacción 0 asignados Ver en GitHub
Lenguaje dominante
Dart
Estrellas
684
Forks
329
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

### Bug Description

When using AppFlowyEditor with EditorScrollController(shrinkWrap: true) and reusing the same EditorState instance, the app throws a “ValueNotifier was used after being disposed” exception after navigating away and reopening the page.

This happens because EditorScrollController adds a listener to editorState.document.root when shrinkWrap is enabled, but never removes it in dispose().
When the editor is rebuilt or reopened, the stale listener still tries to update the disposed visibleRangeNotifier or offsetNotifier, causing the crash.

### How to Reproduce

Create an editor page that uses a persistent EditorState:

final editorState = EditorState.blank(withInitialText: true);

Inside your page, use:

AppFlowyEditor(
editorState: editorState,
shrinkWrap: true,
)

Navigate away from the page (so the widget and controller are disposed).

Navigate back to the same page using the same editorState.

Try typing or editing text — the exception appears:

A ValueNotifier was used after being disposed.

### Expected Behavior

The editor should work normally when reopened, even when reusing the same EditorState.
No exceptions should occur from disposed notifiers or stale listeners.

### Operating System

IOS, Android

### AppFlowy Editor Version(s)

5.2.0

### Screenshots

_No response_

### Additional Context

_No response_

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.