AppFlowy-IO / AppFlowy-IO/appflowy-editor

[Bug] Type error from TableBlockKeys.colsHeight int being used where double? is expected

Ouverte
#1,144 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Dart
Étoiles
684
Forks
329
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

### Bug Description

I see various type error issues related to a table colsHeight holding an int and being used where a double is expected.

I would love to help, but unfortunately do not have time. So, I hope it is useful to just report what I see in the error reporting service I use.

**_TableColBorderState.buildFixedBorder. (table_col_border.dart:89)**
_Container.height seem to expect a double and complains when getting an int from TableBlockKeys.colsHeight_
```dart
Container buildFixedBorder(BuildContext context) {
return Container(
width: widget.tableNode.config.borderWidth,
height: context.select(
(Node n) => n.attributes[TableBlockKeys.colsHeight],
),
color: Colors.grey,
);
}
```

**_TableColBorderState.buildResizableBorder. (table_col_border.dart:75)**
_Same issue with Container.height expecting a double_
```dart
},
child: Container(
key: _borderKey,
width: widget.tableNode.config.borderWidth,
height: context.select(
(Node n) => n.attributes[TableBlockKeys.colsHeight],
),
color: _borderHovering || _borderDragging
? widget.borderHoverColor
: widget.borderColor,
),
```

### How to Reproduce

I'm unfortunately not sure what users have done, but I currently see the issue reported only on Android. I primarily test on web currently and have not experienced the issue or caught errors in the console logs.

### Expected Behavior

I would expect that the editor component doesn't throw errors like this.

### Operating System

Android

### AppFlowy Editor Version(s)

6.1.0

### Screenshots

_No response_

### Additional Context

I use Flutter 3.35.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.