AppFlowy-IO / AppFlowy-IO/AppFlowy-Web

[Bug] Refactor this function to not always return the same value.

Abierto
#406 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
TypeScript
Estrellas
326
Forks
167
Merge medio
17 h 6 min
PR fusionados (30 d)
72

Descripción

### Bug Description

The intention of this function is not clear. Take a look.
``` JavaScript
const shouldShowForCurrentView = useCallback(() => {
if (!currentView) return true;

// Show for all views
return true;
}, [currentView]);
```

Did you mean false in the `if` statement?

### Steps to Reproduce

Take a look at the function and tell if there is any logic in it. What was the original intent?

### Expected Behavior

Should return different values or this is not needed at all.

### Browser and Version

Edge latest

### AppFlowy Version(s)

0.15

### Screenshots

_No response_

### Logs and Console Output

_No response_

### Additional Context

_No response_

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.