AntiMicroX / AntiMicroX/antimicrox

Refactor constructors of some classes

Abierto
#554 2 comentarios 0 reacciones 0 asignados Ver en GitHub
good first issue low-priotity refactor
Lenguaje dominante
C++
Estrellas
4k
Forks
249
Merge medio
13 min
PR fusionados (30 d)
1

Descripción

Classes like `ButtonEditDialog` `JoyButtonSlot` (and probably many other) have many duplications in overrides constructors.

For example

```cpp
JoyButtonSlot::JoyButtonSlot(QObject *parent)
: QObject(parent)
, extraData()
{
deviceCode = 0;
m_mode = JoyKeyboard;
m_distance = 0.0;
previousDistance = 0.0;
qkeyaliasCode = 0;
easingActive = false;
mix_slots = nullptr;
}

JoyButtonSlot::JoyButtonSlot(int code, JoySlotInputAction mode, QObject *parent)
: QObject(parent)
, extraData()
{
deviceCode = 0;
qkeyaliasCode = 0;

if (code > 0)
deviceCode = code;

m_mode = mode;
m_distance = 0.0;
easingActive = false;
mix_slots = nullptr;
}

JoyButtonSlot::JoyButtonSlot(int code, int alias, JoySlotInputAction mode, QObject *parent)
: QObject(parent)
, extraData()
{
deviceCode = 0;
qkeyaliasCode = 0;

if (code > 0)
deviceCode = code;

if (alias > 0)
qkeyaliasCode = alias;

m_mode = mode;
m_distance = 0.0;
easingActive = false;
mix_slots = nullptr;
}
```
Instead of duplicating code, these constructors could call each other

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.