Androz2091 / Androz2091/discord-player

A tracks stream isnt fetched from the metadata extractor first, and it expects a URL even tho it shoudn't be necessary

Ouverte
#1,993 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
bug
Langage dominant
TypeScript
Étoiles
638
Forks
197
Merge moyen
2 min
PR mergées (30 j)
1

Description

**Describe the bug**
The check for which extractor can stream doesn't prioritize the extractor used for metadata querying. It also uses the tracks URL, which might not exist for certain extractor types.

**To Reproduce**
Steps to reproduce the behavior:
Have multiple extractors, easier when one works purely with protocol

**Expected behavior**
Start first with the extractor that got the metadata, then fallback to other, and also not try to validate with query url as certain extractors don't use it.
https://github.com/Androz2091/discord-player/blob/df5744d40a3591a551a97dcf740759e841f98caa/packages/discord-player/src/queue/GuildQueuePlayerNode.ts#L985-L1003

**Screenshots**

![Image](https://github.com/user-attachments/assets/36c62e56-ef8f-49a7-9280-21ff5b55b172)

**Please complete the following information:**
- Node Version: 22.11.0
- Discord Player Version: 7.0.0+
- Discord.js Version: 14.19.3

**Additional context**

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.