Anders429 / Anders429/serde_args

Consider making `shape::Variant` an enum

未關閉
#8 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Rust
星號
3
分支
0
PR 合併指標
30 天內沒有已合併 PR

描述

As it currently is, there is some ambiguity for struct variants vs newtype variants containing a struct. This caused some issues with #2, but even with that fixed, I still feel like it should probably be handled separately. Also notable are unit variants vs. newtype variants containing units (although the difference there doesn't seem to be as much of an issue, since something like #2 could never happen with the unit variants).

Currently, although #2 is fixed, if you use an alias on a struct variant you'll end up with a name in the generated help text that doesn't match the alias you use. I would rather have it directly match the alias that is currently being used, instead of a random one being picked (which, due to how `serde_derive` handles aliases, often ends up being an alias instead of the original name).

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。