AmpleOrganics / AmpleOrganics/Blaze.vue

AoInput, AoSelect, AoTextarea, AoFileUpload: use aria-label when input label is hidden

Aperta
#334 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Vue
Stelle
6
Fork
2
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

# Issue summary

Currently you must provide labels for inputs, but have the ability to hide them. This was for accessibility reasons but it doesn't really actually get it right. display: none also hides text from screen readers. The correct way is to use aria-label, per https://www.w3.org/TR/WCAG20-TECHS/ARIA14.html

# Solution
For all these input components, put something that does this inside the input/select/textarea/whatever tag
```
If showLabel = false
aria-label="{{ label }}"
```

We could also just not render the `` element, and/or make this non mandatory. Won't really make a difference, so probably just preference.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.