AltraMayor / AltraMayor/gatekeeper

Review `time_resolution_init()`

Ouverte
#82 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
enhancement good first issue
Langage dominant
C
Étoiles
1.6k
Forks
252
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Function `time_resolution_init()` located in file `main/main.c` estimates the frequency of the TSC register and sets its result in a couple global variable in different units (e.g. `cycles_per_sec`). DPDK has function `rte_get_tsc_hz()`, which is equivalent to the global variable `cycles_per_sec`.

Which function is more precise, `time_resolution_init()` or `rte_get_tsc_hz()`? If `time_resolution_init()`, we should submit a patch to DPDK. In any case, we should adopt `rte_get_tsc_hz()` in `time_resolution_init()` to simplify our code.

We should also investigate if the global variables are still needed. For example, should we replace variable `cycles_per_sec` with `rte_get_tsc_hz()` or keep it?

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.