AltraMayor / AltraMayor/gatekeeper

Free mbuf memory pools

未关闭
#697 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
enhancement
主要语言
C
星标
1.6k
派生
252
PR 合并指标
30 天内没有已合并 PR

描述

Flesh out `include/gatekeeper_net.h:destroy_mempool()` using `rte_mempool_free()`. This change will require reviewing the functions that release resources at termination because the current code does not account for the proper release of mbuf memory pools. A simple test of this change produces a segmentation fault while Gatekeeper is shutting down with the following (simplified) backtrace: `... -> bond_mode_8023ad_periodic_cb() -> ... -> rte_is_zero_ether_addr()`. The probable cause of this segmentation fault is that memory pools are being released before the underlying interfaces are cleared.

The code review should also consider the possibility of assigning `NULL` to variables after the release of the associated resources to increase the chances of quickly identifying bugs in the future.

It is worth pointing out that this issue is not a problem since associated memory is automatically released once Gatekeeper terminates, so there is no immediate demand for it. However, it is a nice feature since it tightens the code.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。