AltraMayor / AltraMayor/gatekeeper

struct flow_entry does not need field in_use

Open
#603 0 comments 0 reactions 0 assignees View on GitHub
enhancement good first issue
Dominant language
C
Stars
1.6k
Forks
252
PR merge metrics
No merged PRs in 30d

Description

The field `in_use` of `struct flow_entry` can be replaced with the following inline function:
```c
static inline bool
flow_entry_in_use(const struct flow_entry *fe)
{
return fe->grantor_fib != NULL;
}
```
The field `grantor_fib` must be set for GK blocks to know how to forward packets to Grantor servers or the actual destination, so it is always set for entries in use.

Dropping field `in_use` is just one more step to streamline `struct flow_entry`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.