AltimateAI / AltimateAI/datapilot-cli

Ensure compatibilty with pydantic v1

未关闭
#62 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
43
派生
2
平均合并
4 天 6 小时
30 天内合并 PR
2

描述

The main issue with using model_dump in Pydantic v1 is that this method doesn't exist in Pydantic v1. It was introduced in Pydantic v2 as part of the new serialization API.

The key evidence in your code:

1 src/datapilot/core/platforms/dbt/schemas/manifest.py uses BaseModel from Pydantic
2 Your Altimate* classes all inherit from BaseModel
3 In Pydantic v1, you should use .dict() or .json() for serialization instead
4 No indication of any compatibility layer for v1/v2 transitions

If the code attempts to call .model_dump() while running under Pydantic v1, it will raise:


`AttributeError: 'AltimateManifestNode' object has no attribute 'model_dump' `

💡 Recommendations if you need v1 compatibility:

1 Replace model_dump() with .dict())
2 Add version detection:


```
import pydantic

if pydantic.version.VERSION.startswith("1"):
return obj.dict()
else:
return obj.model_dump()
```

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。