AltimateAI / AltimateAI/altimate-code

test: behavioral regression test that MCP tool calls enforce the permission check

Aperta
#997 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
811
Fork
134
Merge medio
3g 2h
PR unite (30g)
50

Descrizione

Found during v0.9.1 release review (CTO + Tech-Lead). The security fix e7ec6a9b29 (MCP tools ran with NO permission check — an Effect awaited but never run) has only grep-for-string coverage (`v140-merge-adversarial.test.ts`), which would pass even with the bug present. Add a test that drives an MCP tool call end-to-end through `session/prompt.ts` and asserts `PermissionNext.ask` is actually invoked / the call is gated. Prevents silent reintroduction on refactor.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.