AltimateAI / AltimateAI/altimate-code

test: behavioral regression test that MCP tool calls enforce the permission check

Open
#997 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
811
Forks
134
Avg merge
3d 2h
Merged PRs (30d)
50

Description

Found during v0.9.1 release review (CTO + Tech-Lead). The security fix e7ec6a9b29 (MCP tools ran with NO permission check — an Effect awaited but never run) has only grep-for-string coverage (`v140-merge-adversarial.test.ts`), which would pass even with the bug present. Add a test that drives an MCP tool call end-to-end through `session/prompt.ts` and asserts `PermissionNext.ask` is actually invoked / the call is gated. Prevents silent reintroduction on refactor.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.