AltimateAI / AltimateAI/altimate-code
security: wire verifyEnvelope into the consume side + constant-time compare + reject unkeyed-when-key-set
- 主要語言
- TypeScript
- 星號
- 811
- 分支
- 134
- 平均合併
- 3 天 2 小時
- 30 天內合併 PR
- 50
描述
Found during v0.8.1 release review (Chaos Gremlin / security auditor). Pre-existing, not regressed by v0.8.1.
`verifyEnvelope` (verdict.ts:~196) is only called in tests — no consumer (gate decision / replay audit) actually verifies the HMAC before trusting a verdict envelope, so signing is currently produce-only (proves who-produced, not who-can-reject). Also: (1) it uses plain `===` string compare on the HMAC instead of `crypto.timingSafeEqual`; (2) when `ALTIMATE_REVIEW_SIGNING_KEY` is unset it falls back to an unkeyed `sha256:` digest that still 'verifies' — an envelope can be silently re-forged if the key is absent.
Fix: wire verifyEnvelope into the consuming/gate path; use timingSafeEqual over equal-length buffers; reject when the stored signature is the unkeyed `sha256:` form while a key is configured. Deferred because it needs its own design + review (signing-soundness change), not a patch-release rush.
貢獻指南
評估
這個 Issue 還沒有評估資料。