AltimateAI / AltimateAI/altimate-code

security: wire verifyEnvelope into the consume side + constant-time compare + reject unkeyed-when-key-set

Open
#873 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
811
Forks
134
Avg merge
3d 2h
Merged PRs (30d)
50

Description

Found during v0.8.1 release review (Chaos Gremlin / security auditor). Pre-existing, not regressed by v0.8.1.

`verifyEnvelope` (verdict.ts:~196) is only called in tests — no consumer (gate decision / replay audit) actually verifies the HMAC before trusting a verdict envelope, so signing is currently produce-only (proves who-produced, not who-can-reject). Also: (1) it uses plain `===` string compare on the HMAC instead of `crypto.timingSafeEqual`; (2) when `ALTIMATE_REVIEW_SIGNING_KEY` is unset it falls back to an unkeyed `sha256:` digest that still 'verifies' — an envelope can be silently re-forged if the key is absent.

Fix: wire verifyEnvelope into the consuming/gate path; use timingSafeEqual over equal-length buffers; reject when the stored signature is the unkeyed `sha256:` form while a key is configured. Deferred because it needs its own design + review (signing-soundness change), not a patch-release rush.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.