AltimateAI / AltimateAI/altimate-code

data_diff: configurable MAX_STEPS and wall-clock timeout

Aperta
#720 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
811
Fork
134
Merge medio
3g 2h
PR unite (30g)
50

Descrizione

Flagged during v0.5.22 release review (End User + Tech Lead personas).

`MAX_STEPS = 200` in `packages/opencode/src/altimate/native/connections/data-diff.ts` is hardcoded. The error message now suggests `partition_column` / `where_clause` remediations (good), but:

- No per-query wall-clock timeout — runaway cross-database HashDiff can hang and rack up warehouse cost
- No user override for legitimate billion-row table cases
- No telemetry breadcrumb when we hit the cap

Proposed:
- `data_diff_max_steps` config, default 200
- Per-SQL-step wall-clock timeout (60s default, configurable)
- Emit telemetry event on cap hit so we know how often users need more headroom

Deferred because: no reported hits in the field yet. File for tracking.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.