AltimateAI / AltimateAI/altimate-code

Hardcoded `dialect: "snowflake"` across altimate-core tools

Abierto
#455 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
TypeScript
Estrellas
811
Forks
134
Merge medio
3 d 2 h
PR fusionados (30 d)
50

Descripción

## Problem

The altimate-core tools don't expose a `dialect` parameter — they always target Snowflake internally. The `sql_quality` telemetry event supports an optional `dialect` field, but only the sql-* tools (analyze, optimize, schema-diff) populate it since they accept dialect as a user parameter.

### Tools missing dialect support

- `altimate-core-validate.ts`
- `altimate-core-fix.ts`
- `altimate-core-correct.ts`
- `altimate-core-semantics.ts`
- `altimate-core-equivalence.ts`
- `altimate-core-policy.ts`
- `altimate-core-check.ts`
- `impact-analysis.ts`

### Tools that already support dialect

- `sql-analyze.ts` — `dialect` parameter, passed to dispatcher and telemetry
- `sql-optimize.ts` — same
- `schema-diff.ts` — same

### Proposed fix

1. Add an optional `dialect` parameter to all altimate-core tools (defaulting to `"snowflake"`)
2. Pass the dialect through to the Dispatcher call
3. Include `dialect` in metadata so telemetry picks it up

This enables per-dialect telemetry segmentation and prepares these tools for multi-dialect support (postgres, bigquery, duckdb, etc.).

### Context

Identified during PR #446 (`sql_quality` telemetry). Rather than hardcoding `dialect: "snowflake"`, we made the telemetry field optional — tools that don't set it simply omit it from the event.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.