AlphaWallet / AlphaWallet/alpha-wallet-android

Add 'signTransaction' method to DappBrowser

Aperta
#3,102 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Free for all
Lingua principale
Java
Stelle
646
Fork
579
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

The DappBrowser still does not handle 'Sign Transaction only'.

*I think* to handle this we will need to add an additional shim in the init.js provider which is identical to the 'processTransaction' hook, only called 'processSignTransaction'. This hooks into the sign transaction code in the AlphaWallet Provider (alphawallet.js). I have added all the backend methods to handle signing only in DappBrowserFragment and DappBrowserViewModel.

Investigate how to do this - you will probably need to write a dapp that has the signTransaction method as I couldn't find any. Suggestion: use the code here: https://github.com/JamesSmartCell/JamesSmartCell.github.io and add the sign Transaction. You'd need to check the signature of the RLP code you receive, so you'll need to use Ethers.js for that - I think I already included it.

Once this is in, we can re-deploy and use it as a handy testbed.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.