AlphaWallet / AlphaWallet/alpha-wallet-android

Walletconnect issues to Gnosis Safe + Android ends the active session with WalletConnect, due to gas-limit settings.

オープン
#1,858 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
Java
スター
646
フォーク
579
PR マージ指標
30日以内にマージされた PR はありません

説明

[hat tip to bsh666]

**Situation:**

Trying to connect alphawallet mobile app with Gnosis Safe via walletconnect as a signer wallet.

**Issue #1: WalletConnect issues to Gnosis Safe**

Not able to scan gnosis walletconnect code though is the camera would not focus in portrait mode. It does focus in landscape mode, but then it still does not scan, the bar code cannot fit in the scan rectangle in this mode. Finally managed to do it on landscape and got the phone far enough to fit the barcode into the rectangle. It became too small and took a few attempts to scan.

Phone: Huawei P9 EVA-AL10 with Android 8

**Request #1:**

- Since this needs to be done every time I need walletconnect, I hope you could fix this at some point

- Going from landscape to portrait mode or vice versa tends to break up walletconnect session, and on landscape mode you cannot see the confirm button. You really need to work on testing both modes

**Issue #2: Android ends active session with WalletConnect, due to gas-limit**

2. If the app is closed by Android memory management while walletconnect session is active, it will destroy the session. I had to start my safe creation all over again. Maybe think about persisting this session somehow as it seems very fragile now.

3. When I finally managed to create my safe, I tried to send some small test funds from AlphaWallet to the safe address. However it failed repeatedly due to "out of gas error". I finally figured out, cause it was smart contract it requires more gas to complete the tx. The standard 21000 gas limit that you have would not do it. I set i to 40 000 and then it completed with:Gas Limit:
40,000
Gas Used by Transaction:
25,918 (64.8%)

**Request #2:**

I think you should detect that the receiver is a small contract and include a higher limit in that case. Same for other stuff like ICO tokens, etc Or if it is not possible include some kind of toggle so people can choose those types and then you could change your defaults accordingly.

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。