AllenNeuralDynamics / AllenNeuralDynamics/prototome-web-ui

Consolidate Mapping of received streams to component and function calls to component

Aperta
#10 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
0
Fork
0
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

This is really two related issues:

#### React component to instrument call (output)
Currently for mapping react component output (buttons, sliders, etc) to instrument functionality, we need to change a specific json string message in each component to match a specific function call on the instrument.

#### instrument (one-liner streams) to react component (input)
For mapping stream names to one-liner functionality, we need to

Stream names and their corresponding functionality is hardcoded.

Specific string names are used across the codebase by various react components to receive instrument input. While these names are called out in **web_ui_config.json**, it's not clear what they correspond to. A one-liner stream needs to be marked with the same stream name and provide the right return type for use by the component.

Example: `prototome_stage_positions` is identified as a data channel in **web_ui_config.json**, and then `prototome_stage_positions` is used in **StagePosVis.tsx**. Elsewhere, a one-liner stream needs to be marked as `prototome_stage_positions` and provide the right return type for the react component to use the information.

#### The Fix
Let's migrate towards having all input/output functionality mapped to a single config file where react components and instrument functionality is outlined in this config.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.