AllenNeuralDynamics / AllenNeuralDynamics/prototome-web-ui

Consolidate Mapping of received streams to component and function calls to component

未关闭
#10 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
TypeScript
星标
0
派生
0
PR 合并指标
30 天内没有已合并 PR

描述

This is really two related issues:

#### React component to instrument call (output)
Currently for mapping react component output (buttons, sliders, etc) to instrument functionality, we need to change a specific json string message in each component to match a specific function call on the instrument.

#### instrument (one-liner streams) to react component (input)
For mapping stream names to one-liner functionality, we need to

Stream names and their corresponding functionality is hardcoded.

Specific string names are used across the codebase by various react components to receive instrument input. While these names are called out in **web_ui_config.json**, it's not clear what they correspond to. A one-liner stream needs to be marked with the same stream name and provide the right return type for use by the component.

Example: `prototome_stage_positions` is identified as a data channel in **web_ui_config.json**, and then `prototome_stage_positions` is used in **StagePosVis.tsx**. Elsewhere, a one-liner stream needs to be marked as `prototome_stage_positions` and provide the right return type for the react component to use the information.

#### The Fix
Let's migrate towards having all input/output functionality mapped to a single config file where react components and instrument functionality is outlined in this config.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。