AllenNeuralDynamics / AllenNeuralDynamics/one-liner

Attach json schema for Pydantic Models in `get_stream_configuration()`

Aperta
#60 0 commenti 0 reazioni 1 assegnatario Rivendicata da @jessy-liao Vedi su GitHub
Lingua principale
Python
Stelle
3
Fork
0
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

When we call `get_stream_configuration()`, we create a dict with metatdata related to each stream including the type. Type information is deduced from the connected function's return type. If the return type is a pydantic model, however, we return the string representation of that model since the client recipient can't deserialize it if it doesn't have the associated dependency required to understand the model.

What we should do instead is return a json schema associated with that model either *instead-of* or *in-addition-to* the annotated return type. Returning the json schema provides full information into a nested dictionary-like object, which means it's likely more detailed than, let's say, annotating a function's return type with just `dict`.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.