AllenNeuralDynamics / AllenNeuralDynamics/aind-ophys-decrosstalk-roi-images

Pass images instead of filenames to certain methods in decrosstalk

Offen
#19 0 Kommentare 0 Reaktionen 1 zugewiesene Person Beansprucht von @arielleleon Auf GitHub ansehen
Vorherrschende Sprache
Python
Sterne
0
Forks
0
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

From this PR: https://github.com/AllenNeuralDynamics/aind-ophys-decrosstalk-roi-images/pull/18

From @jkim0731
Instead of passing paths and frame index, can we re-factor def decrosstalk_roi_image_single_pair_from_episodic_mean_fov to take two images only? (on top of pixel_size, grid_interval, and max_grid_val). I think that was what BOQC had, I don't understand the need to passing fn and frame index instead.

From @jkim0731
If this refactoring possible, L202, p1y, p1x = get_motion_correction_crop_xy_range_from_both_planes(oeid, paired_id, input_dir) can be brought up one level to here and be calculated only once.

These are very valid comments but I will need to refactor a bit to pass in images to the functions. BOQC had the LIMS db to pull from and I will need to add better folder queries to get relevant filepaths.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.