Load from h5.

Open
#324 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
55/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start in bmtk/simulator/pointnet/pointsimulator.py around line 247 and compare its spike-train loading behavior with bmtk/simulator/bionet/biosimulator.py around line 349. Determine how the bionet loader handles supported formats and whether h5 and hdf5 should be accepted there as in pointnet. Done means the intended h5/hdf5 behavior is implemented consistently and verified against the existing loading path.

Written by the indexing model from the issue text.

Description

In simulator/pointnet/pointsimulator.py (L247), the code to load spike trains is:
https://github.com/AllenInstitute/bmtk/blob/ae9c24c415a3fbd60397b4ead160b72b4b3e4e4f/bmtk/simulator/pointnet/pointsimulator.py#L247
Why are 'h5' and 'hdf5' not included in the same function in /simulator/bionet/biosimulator? https://github.com/AllenInstitute/bmtk/blob/ae9c24c415a3fbd60397b4ead160b72b4b3e4e4f/bmtk/simulator/bionet/biosimulator.py#L349

Dominant language
Python
Stars
335
Forks
102
Avg merge
1d 5h
Merged PRs (30d)
6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from AllenInstitute/bmtk

All issues in AllenInstitute/bmtk

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.