AllenInstitute / AllenInstitute/bmtk
"TwoSubfieldLinearCell" saves the dominant_filter amplitude for nondominant_filter unit
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 335
- Forks
- 102
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 6
Description
In line 57-60 of bmtk/simulator/filternet/lgnmodel/cellmodel.py, the dominant_unit and nondominant_unit are created as:
self.dominant_unit = LNUnit(self.dominant_filter, ScalarTransferFunction('s'),
amplitude=self.dominant_filter.amplitude)
self.nondominant_unit = LNUnit(self.nondominant_filter, ScalarTransferFunction('s'),
amplitude=self.dominant_filter.amplitude)
This looks strange to me, as the nondominant_unit should save the amplitude as self.nondominant_filter.amplitude.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect bmtk/simulator/filternet/lgnmodel/cellmodel.py at lines 57-60, where the dominant_unit and nondominant_unit amplitudes are assigned. Compare each unit with its corresponding filter and confirm that the nondominant unit preserves the nondominant filter amplitude; verify the surrounding cell-model behavior afterward.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 65/100