AllenFang / AllenFang/react-bootstrap-table

Keyboard navigation when there are hidden columns.

Open
#1,894 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.2k
Forks
761
PR merge metrics
No merged PRs in 30d

Description

Hi @AllenFang, thank you for the amazing library, I love it!

It looks like there is an issue with keyboard navigation in 4.3.1 when there are hidden columns. To replicate it you can create a table with any of the columns hidden and keyboard navigation enabled. It looks like you planned for it by adding the visibleColumnSize variable, but variable 'x' still contains absolute column number.
What I did, is added an visibleColumnIndices array with indices of the non-hidden columns and made 'x' take only values from it.

Associated pull request: #1893.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.