AllenFang / AllenFang/react-bootstrap-table

Potential performance issue...

Aperta
#1,345 9 commenti 2 reazioni 0 assegnatari Vedi su GitHub
enhancement
Lingua principale
JavaScript
Stelle
2.2k
Fork
761
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

I noticed very slow performance on one of my pages that uses react bootstrap table.

Specifically, when I type text into a field on my page, it is very slow for the text to appear. Of course reactjs does a rerender with every keypress in the field.

So I wondered if maybe with every rerender that react-bootstrao-table was rerendering.

So I ran npm install why-did-you-update and on my page at the top I put:

import {whyDidYouUpdate} from 'why-did-you-update'
whyDidYouUpdate(React)

The output in the console says that react-boostrap-table is doing alot of possibly unnecessary updates, and because it the table is complex, it slows the entire page down quite dramatically because the bootstrap table re-renders with every keypress in my input fields, even though the input fields have nothing to do with the react-bootstrap-table.

So I am wondering, is it possible that react-bootstrap-table is rerendering even when it does not get new props that require it to update?

And great work Allen - I love the table and use it for all my projects!

thanks!

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.