AllenCell / AllenCell/vole-core

internals: setState api and efficient render updates

オープン
#90 コメント 3 件 リアクション 0 件 担当者 1 名 @frasercl が担当を希望しています GitHub で見る
Tech Debt
主要言語
TypeScript
スター
106
フォーク
11
平均マージ
3日 51分
マージ済み PR(30日)
12

説明

## Use Case

As a developer, the public api is too spread out over many functions that have partial side effects.
We would like to be able to update large chunks of state with only one function call.

## Solution

Copy the data structure from https://github.com/allen-cell-animated/website-3d-cell-viewer/issues/110 down into volume-viewer and export it.
Partially implement the react-like state update mechanism as discussed in Teams call in volume-viewer, starting only with VolumeOptions (our temporary name for the appearance and channel editing information).
We believe this can be implemented at low technical risk as an alternate code path that doesn't modify any of the other public api or internal Drawable classes.
After some nontrivial tbd amount of functionality is in, we can assess the impact on performance and code maintainability/readability.

The end goal which may require followup issues is to have all settings updated via this mechanism and remove the individual setters in the api. A requirement for the final goal will be to have good documentation of the whole data structure and a clear path forward for future modifications.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。