AllenCell / AllenCell/vole-core

Change `three` to a peer dependency

Ouverte
#303 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
Tech Debt
Langage dominant
TypeScript
Étoiles
106
Forks
11
Merge moyen
3 j 51 min
PR mergées (30 j)
12

Description

## Use Case

Having multiple versions of `three` usually causes conflicts, because `three` expects only a single version to be installed. `vole-core` requires `three`, but users of `vole-core` often need to install `three` as well.

From what I understand, adding `three` as a peer dependency could help throw more explicit warnings if incompatible versions are installed! (Though A. I could be wrong and B. `three` doesn't use semver...)

## Solution

- Add `three` to the list of peer dependencies in `package.json`.

## Alternatives

_Please describe any alternatives you've considered, even if you've dismissed them_

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.