AllenCell / AllenCell/cell-feature-explorer

Race condition in `promote.yml` causes deploys to be skipped

未关闭
#281 0 条评论 0 个 reaction 已指派 1 人 已被 @ShrimpCryptid 认领 在 GitHub 查看
bug Tech debt
主要语言
TypeScript
星标
2
派生
1
PR 合并指标
30 天内没有已合并 PR

描述

## Use Case

Currently, the `deploy.yml` action triggers on any pushes to the `main` branch, and writes to the staging bucket.

The `promote.yml` action triggers on new tags pushed to `main`, and copies the contents of the staging bucket to the production bucket.

When a new commit with a release tag is made, both of these actions trigger at the same time, and `promote.yml` usually completes before `deploy.yml` can build and write to the staging bucket. This causes a race condition where the release made in the production bucket is one version out of date.

## Solution

Chain the `deploy.yml` and `promote.yml` actions together, possibly by making them part of the same action, to prevent the race condition.

## Alternatives

_Please describe any alternatives you've considered, even if you've dismissed them_

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。