AllenCell / AllenCell/allencell-segmenter-ml

returns optional pattern

Open
#522 0 comments 0 reactions 0 assignees View on GitHub
refactor
Dominant language
Python
Stars
5
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Our practice of doing null checks on fields returned by getters whose value can be null (in order to satify `mypy` linter) really feels like an anti pattern, especially when we handle null values by throwing an error

https://github.com/AllenCell/allencell-segmenter-ml/pull/519#discussion_r1779307204

Could the error just be thrown internal to the getter, for violating an invariant?

We need research into how type checking in Python should be done.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.