AllenCell / AllenCell/allencell-segmenter-ml

TrainingView.showResult refactor

Open
#521 0 comments 0 reactions 0 assignees View on GitHub
refactor
Dominant language
Python
Stars
5
Forks
3
PR merge metrics
No merged PRs in 30d

Description

In the current design:

We have now overloaded `showResult` in the Training view with functionality unrelated to showing results. IMO we should abstract `View.showResult` to something like `View.LongRunningTaskOnComplete` which then calls `showResultDialog` and `mainModel.training_complete`.

However...

Our refactor plans include refactoring the entire LongRunningTask mechanism. So this info could be incorporated in our replacement, or it could end up being a mute point.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.