Alir3z4 / Alir3z4/python-currencies

Make Currencies comparable

未关闭
#16 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
73
派生
13
PR 合并指标
30 天内没有已合并 PR

描述

Hi there!
Out of curiosity, was there any decision behind not implementing the `__eq__` method inside the Currency class?

In my - maybe naive - understanding, it would make sense to be able to compare Currency objects like so:
``
Currency('USD') == Currency('USD')
``
which as of now returns False, as the object's pointers are compared, not the values.

My workaround for this is as follows (python 3.10 code, for python < 3.10 the `__ne__` method also needs to be implemented)
```python
class ComparableCurrency(Currency):
def __eq__(self, other):
return isinstance(other, Currency) and self.get_money_currency() == other.get_money_currency()
```

If for any reason, it doesn't make sense to compare two Currencies with each other, or the implementation on `currency.get_money_currency()` is too simple, I would really like to undestand the problems with that.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。