Alir3z4 / Alir3z4/html2text

Sometimes img src can be in attrs "data-src" instead of "src"

Open
#350 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
2.2k
Forks
296
PR merge metrics
No merged PRs in 30d

Description


- html2text version: 2020.1.16
- Python version: 3.8.5

example url: [https://jingyan.baidu.com/article/4dc40848741808c8d946f18a.html](https://jingyan.baidu.com/article/4dc40848741808c8d946f18a.html) or WeChat articles.

I can not get all the images in such html. So I manually change the code of my local installed html2text and it works.

```python
# original code in __init__.py: function handle_tag()
if tag == "img" and start and not self.ignore_images:
if "src" in attrs:
assert attrs["src"] is not None
if not self.images_to_alt:
attrs["href"] = attrs["src"]
alt = attrs.get("alt") or self.default_image_alt

# If we have images_with_size, write raw html including width,
# height, and alt attributes
if self.images_as_html or (
self.images_with_size and ("width" in attrs or "height" in attrs)
):
self.o("

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.