`None` link title assert hit
- Ngôn ngữ chính
- Python
- Star
- 2.2k
- Fork
- 296
- Chỉ số merge pull request
- Không có pull request nào được merge trong 30 ngày
Mô tả
There is the following in the code:
https://github.com/Alir3z4/html2text/blob/24aac8629f6a50ab262727815107384e0682cf42/html2text/__init__.py#L781
Of course someone managed to produce html with links of the form `…` that trigger this assert. I think better than having the assert would be to replace
https://github.com/Alir3z4/html2text/blob/24aac8629f6a50ab262727815107384e0682cf42/html2text/__init__.py#L780
with
```
link_attrs_title = link.attrs.get("title", None)
if link_attrs_title is not None:
```
N.B.: The same type of pattern fixable in the way can be found on three other occasions:
* https://github.com/Alir3z4/html2text/blob/24aac8629f6a50ab262727815107384e0682cf42/html2text/__init__.py#L502
* https://github.com/Alir3z4/html2text/blob/24aac8629f6a50ab262727815107384e0682cf42/html2text/__init__.py#L514
* https://github.com/Alir3z4/html2text/blob/24aac8629f6a50ab262727815107384e0682cf42/html2text/__init__.py#L517
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.