proposal - default bodywidth to `None`
Abierto
- Lenguaje dominante
- Python
- Estrellas
- 2.2k
- Forks
- 296
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
`bodywidth` is currently specified in an init argument, defaulting to `config.BODY_WIDTH`.
https://github.com/Alir3z4/html2text/blob/master/html2text/__init__.py#L43
A problem with this approach: the `__init__` function creates the default value for bodywidth when it is interpreted. changing the value of `config.BODY_WIDTH`after importing html2text will have no effect.
I propose the following:
1. change the init value `bodywidth=None`
2. change the following line:
```
- self.body_width = bodywidth # covered in cli
+ self.body_width = bodywidth if bodywidth is not None else config.BODY_WIDTH # covered in cli
```
Guía de contribución
Evaluación
Este issue todavía no se ha evaluado.