AlibabaResearch / AlibabaResearch/DAMO-ConvAI

QueryHistoryToday description mismatch

Offen
#142 3 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Python
Sterne
1.6k
Forks
250
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

## Issue

The [description of the `QueryHistoryToday` API](https://github.com/AlibabaResearch/DAMO-ConvAI/blob/main/api-bank/apis/query_history_today.py#L6) in code (`"This API queries the history of the given date."`) does not match the description present in the jsonl files `QueryHistoryToday-level-3-2.jsonl` and `QueryHistoryToday-level-3-3.jsonl` (`"This API queries the history of a given user today."`). This means seems to mean you are guaranteed to fail on these examples given the strict `==` check in the `check_api_call_correctness` method of `tool_search.py`.

## Suggested fixes

1. Change
```
response['output'] == groundtruth['output']
```
to
```
response['api_name'] == groundtruth['api_name']
```
as we only really care that it found the correct API and know what the description of the API is.

2. Update the `jsonl` files to use the correct description.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.