AlibabaResearch / AlibabaResearch/DAMO-ConvAI

QueryHistoryToday description mismatch

Open
#142 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1.6k
Forks
250
PR merge metrics
No merged PRs in 30d

Description

## Issue

The [description of the `QueryHistoryToday` API](https://github.com/AlibabaResearch/DAMO-ConvAI/blob/main/api-bank/apis/query_history_today.py#L6) in code (`"This API queries the history of the given date."`) does not match the description present in the jsonl files `QueryHistoryToday-level-3-2.jsonl` and `QueryHistoryToday-level-3-3.jsonl` (`"This API queries the history of a given user today."`). This means seems to mean you are guaranteed to fail on these examples given the strict `==` check in the `check_api_call_correctness` method of `tool_search.py`.

## Suggested fixes

1. Change
```
response['output'] == groundtruth['output']
```
to
```
response['api_name'] == groundtruth['api_name']
```
as we only really care that it found the correct API and know what the description of the API is.

2. Update the `jsonl` files to use the correct description.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.