AliSoftware / AliSoftware/Reusable

MKMapView support

Abierto
#103 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Swift
Estrellas
3k
Forks
231
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

This library is obviously concentrated on `UITableView` and `UICollectionView` support but `MKMapView` has a lot of the same concepts: registering annotations and dequeuing them.

I currently use a simple extension for that

```swift
extension MKMapView {
final func register(annotationType: T.Type)
where T: Reusable {
self.register(annotationType.self, forAnnotationViewWithReuseIdentifier: annotationType.reuseIdentifier)
}

final func dequeueReusableAnnotation(annotationType: T.Type = T.self) -> T
where T: Reusable {
guard let view = self.dequeueReusableAnnotationView(withIdentifier: annotationType.reuseIdentifier) as? T else {
fatalError(
"Failed to dequeue a annotation view with identifier \(annotationType.reuseIdentifier) matching type \(annotationType.self). "
+ "Check that the reuseIdentifier is set properly in your XIB/Storyboard "
+ "and that you registered the annotation view beforehand"
)
}
return view
}
}
```

I wonder if you be willing to add `MKMapView` support. I can provide this extension as a PR together with some documentation and maybe even a sample.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.