AlgebraicJulia / AlgebraicJulia/AlgebraicDynamics.jl

Performance warning from SciML

未關閉
#125 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
good first issue performance
主要語言
Jupyter Notebook
星號
80
分支
14
PR 合併指標
30 天內沒有已合併 PR

描述

```julia
628
Testing Running tests...
[629](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:632)
Test Summary: | Pass Total Time
[630](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:633)
UWDDynam | 55 55 38.5s
[631](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:634)
Test Summary: | Pass Total Time
[632](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:635)
DWDDynam | 54 54 53.1s
[633](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:636)
Test Summary: | Pass Total Time
[634](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:637)
CPGDynam | 71 71 22.2s
[635](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:638)
┌ Warning: Using arrays or dicts to store parameters of different types can hurt performance.
[636](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:639)
│ Consider using tuples instead.
[637](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:640)
└ @ SciMLBase ~/.julia/packages/SciMLBase/s9wrq/src/performance_warnings.jl:32
[638](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:641)
┌ Warning: Using arrays or dicts to store parameters of different types can hurt performance.
[639](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:642)
│ Consider using tuples instead.
[640](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:643)
└ @ SciMLBase ~/.julia/packages/SciMLBase/s9wrq/src/performance_warnings.jl:32
[641](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:644)
┌ Warning: Using arrays or dicts to store parameters of different types can hurt performance.
[642](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:645)
│ Consider using tuples instead.
[643](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:646)
└ @ SciMLBase ~/.julia/packages/SciMLBase/s9wrq/src/performance_warnings.jl:32
[644](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:647)
┌ Warning: Using arrays or dicts to store parameters of different types can hurt performance.
[645](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:648)
│ Consider using tuples instead.
[646](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:649)
└ @ SciMLBase ~/.julia/packages/SciMLBase/s9wrq/src/performance_warnings.jl:32
```

In the current PR #123 we get some warnings that should be run down. It looks like we are passing parameters as an array instead of a tuple somewhere. This is a good first issue and a potentially breaking change.

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。