Akryum / Akryum/vue-cli-plugin-ssr

registerServiceWorker import not being removed from main.js when using semicolons

Open
#24 1 comment 2 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
441
Forks
69
PR merge metrics
No merged PRs in 30d

Description

Hello, another quick fix here.

When invoking this plugin in a project with the pwa plugin and an eslint config that uses semicolons, the `registerServiceWorker` import line is not removed from `main.js`.

This can be resolved by doing this
```diff
-contents = contents.replace(/import ('|")\.\/registerServiceWorker('|")\n/, ``)
+contents = contents.replace(/import ('|")\.\/registerServiceWorker('|");?\n/, ``)
```

Here https://github.com/Akryum/vue-cli-plugin-ssr/blob/master/generator/index.js#L47

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.