Akryum / Akryum/vue-cli-plugin-ssr
registerServiceWorker import not being removed from main.js when using semicolons
Abierto
- Lenguaje dominante
- JavaScript
- Estrellas
- 441
- Forks
- 69
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
Hello, another quick fix here.
When invoking this plugin in a project with the pwa plugin and an eslint config that uses semicolons, the `registerServiceWorker` import line is not removed from `main.js`.
This can be resolved by doing this
```diff
-contents = contents.replace(/import ('|")\.\/registerServiceWorker('|")\n/, ``)
+contents = contents.replace(/import ('|")\.\/registerServiceWorker('|");?\n/, ``)
```
Here https://github.com/Akryum/vue-cli-plugin-ssr/blob/master/generator/index.js#L47
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Evaluación
Este issue todavía no se ha evaluado.