Akryum / Akryum/vue-cli-plugin-ssr

ESLint reccomended `no-async-promise-executor` broken in example

Abierto
#178 1 comentario 10 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
441
Forks
69
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

The rule `no-async-promise-executor` seems to be set in the recommended group in new versions of ESLint. This trips the following code in the example:

`entry-server.js`
```
return new Promise(async (resolve, reject) => {
const { app, router, apolloProvider } = await createApp({
ssr: true
});
```

I just disabled the rule in my project but I don't fully understand the implications of doing so, so if someone knows a way to fix this in the example I think that'd be great given that this is now a recommended rule.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.