Aiven-Open / Aiven-Open/klaw

💭 Rethink validation pattern for names

未关闭
#578 5 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
discuss
主要语言
Java
星标
195
派生
77
平均合并
8 天 9 小时
30 天内合并 PR
1

描述

Issue was raised her in regards to team contact person: #577

# Description

We've occurrences of the concept of a name (not "username"):
- `KwTenantModel` `contactPerson`
- `TeamModel` `contactPerson`

The validation for these names is currently too strict. e.g. it does not allow Umlaute (ä, ü etc).

It seems (*) that we're not using the concepts of `firstname` `lastname` - which also can be tricky, because this would assume there's always a firstname/lastname and often also comes with the assumption that `lastname` equals to `familiyname` etc.

(*) as far as I could see in a quick skim, backend please jump in and update if that's not tree 🙈

## Notes
Validating names can be tricky (min. character, no special characters etc) and we should look into how we define the concept of "names" in Klaw and if there's room for improvement, also in regards to allowed pattern.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。